This is basically the same as https://github.com/FiloSottile/yubikey-agent/pull/26 but implements the automatic algo selection by checking the firmware version as you mentioned in the other PR. Yubikeys officially added support for Ed25519 keys in firmware version 5.7.0. Upstream piv-go added support for it in https://github.com/go-piv/piv-go/pull/157 (released in `v2.2.0`). Note that Yubikey firmware 5.4.0 (technically 5.4.2 but I used the same version check as piv-go, see [this comment](https://github.com/go-piv/piv-go/pull/149#discussion_r1673855700)) added support for AES management keys so I also used the same firmware version detection method to upgrade the management key to AES256. Tested locally on macOS Sequoia with Yubikey firmware 5.7.1
AI Analysis
This issue appears to be discussing a feature request or bug report related to the repository. Based on the content, it seems to be still under discussion. The issue was opened by e-nomem and has received 1 comments.
Add a comment
Comment form would go here